Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Simplify min_values/max_values into number_of_values (per occurrence) #4001

Merged
merged 11 commits into from Jul 29, 2022
Merged

fix!: Simplify min_values/max_values into number_of_values (per occurrence) #4001

merged 11 commits into from Jul 29, 2022

Commits on Jul 28, 2022

  1. fix(error): Ensure empty possible values isn't shown

    @epage
    epage committed Jul 28, 2022
    Copy the full SHA
    630a489 View commit details
    Browse the repository at this point in the history

  2. test: Verify max_values cases for 0 values

    @epage
    epage committed Jul 28, 2022
    Copy the full SHA
    5444b60 View commit details
    Browse the repository at this point in the history

  3. fix(derive): Make consistent with arg! 

    This has the downside of a regression in `--help`.  We expect to fix
that soon-ish.
    @epage
    epage committed Jul 28, 2022
    Copy the full SHA
    4f756c4 View commit details
    Browse the repository at this point in the history

  4. test: Port macro/derive test to builder 

    Making sure we cover the expected experience from multiple perspectives
    @epage
    epage committed Jul 28, 2022
    Copy the full SHA
    ae803e1 View commit details
    Browse the repository at this point in the history

  5. fix!: Change number_of_values to be per occurrence

    @epage
    epage committed Jul 28, 2022
    Copy the full SHA
    b4dfdce View commit details
    Browse the repository at this point in the history

  6. feat: Extend number_of_values to support min/max per occurrence

    @epage
    epage committed Jul 28, 2022
    Copy the full SHA
    41535d5 View commit details
    Browse the repository at this point in the history

  7. fix: arg!(--long [value]) to per occurrence values 

    Before we did 0..=1 across all occurrences when what we really wanted
was 0..=1 per occurrence.  This makes it compatible with
`ArgAction::Append`.
    @epage
    epage committed Jul 28, 2022
    Copy the full SHA
    ab8ef46 View commit details
    Browse the repository at this point in the history

  8. fix(derive): Make Option<Option<T>> work per occurrence

    @epage
    epage committed Jul 28, 2022
    Copy the full SHA
    cf8e1fc View commit details
    Browse the repository at this point in the history

  9. fix!: Replace min_values (total) with number_of_values (per occur… 

    …rence)
    @epage
    epage committed Jul 28, 2022
    Copy the full SHA
    ccf35ff View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. fix!: Replaced min_values (tota) with number_of_values (per occur… 

    …rence)
    @epage
    epage committed Jul 29, 2022
    Copy the full SHA
    30f5b11 View commit details
    Browse the repository at this point in the history

  2. docs: Provide best practice by example

    @epage
    epage committed Jul 29, 2022
    Copy the full SHA
    eee31e2 View commit details
    Browse the repository at this point in the history