fix!: Make ArgAction::Set the default #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naming is hard. I found I was writing new code without the `s` so that suggests the name was wrong. But we renamed `number_of_values` to `num_args`, so should this be `ArgRange`?
This removes the need for `TakesValue` bookkeeping for when we knew we took values but didn't know how many we should take. Fixes clap-rs#2687
Because of our changes from v3, we can't rely on `_build` taking care of this for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for
TakesValuebookkeeping for when we knew wetook values but didn't know how many we should take.
Fixes #2687