Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Make ArgAction::Set the default #4032

Merged
merged 6 commits into from Aug 6, 2022
Merged

fix!: Make ArgAction::Set the default #4032

merged 6 commits into from Aug 6, 2022

Commits on Aug 5, 2022

  1. refactor: Renamge ValuesRange to ValueRange

    Naming is hard.  I found I was writing new code without the `s` so that
    suggests the name was wrong.  But we renamed `number_of_values` to
    `num_args`, so should this be `ArgRange`?
    epage committed Aug 5, 2022
    Copy the full SHA
    c1468d7 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    8ed35b4 View commit details
    Browse the repository at this point in the history
  3. fix!: Make ArgAction::Set the default

    This removes the need for `TakesValue` bookkeeping for when we knew we
    took values but didn't know how many we should take.
    
    Fixes clap-rs#2687
    epage committed Aug 5, 2022
    Copy the full SHA
    c801e4e View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    0105b65 View commit details
    Browse the repository at this point in the history
  5. fix: Ensure arg! gets help/version correct

    Because of our changes from v3, we can't rely on `_build` taking care of
    this for us.
    epage committed Aug 5, 2022
    Copy the full SHA
    95207a1 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    69ad5cf View commit details
    Browse the repository at this point in the history