fix(usage): Make dont_collapse_args_in_usage the default #4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`last` must always follow a `--`, so it isn't optional.
This was added in clap-rs#165 but the relative value of this doesn't seem worth the complexity at the moment.
The setting was added to resolve clap-rs#769. The reason it was optional is out of concern for applications with a lot of positional arguments. I think those cases are rare enough that we should just push people to override the usage. Positional arguments are generally important enough, even if optional, to show. As a side effect, this fixed some bugs with `dont_collapse_args_in_usage` where it would repeat an argument in a smart usage. As a side effect, smart usage now shows `--` when it should
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setting was added to resolve #769. The reason it was optional is out
of concern for applications with a lot of positional arguments. I think
those cases are rare enough that we should just push people to override
the usage. Positional arguments are generally important enough, even if
optional, to show.
As a side effect, this fixed some bugs with
dont_collapse_args_in_usagewhere it would repeat an argument in asmart usage.
As a side effect, smart usage now shows
--when it shouldAlong the way, misc other usage bugs were fixed
This was
.textsize neutral.This is a part of #4132