Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(usage): Make dont_collapse_args_in_usage the default #4151

Merged
merged 4 commits into from Aug 30, 2022

Commits on Aug 30, 2022

  1. Copy the full SHA
    d791a93 View commit details
    Browse the repository at this point in the history
  2. fix(usage): Don't list -- as optional for last

    `last` must always follow a `--`, so it isn't optional.
    epage committed Aug 30, 2022
    Copy the full SHA
    a00cbab View commit details
    Browse the repository at this point in the history
  3. fix(usage): Don't put in [--] for multiple values

    This was added in clap-rs#165 but the relative value of this doesn't seem worth
    the complexity at the moment.
    epage committed Aug 30, 2022
    Copy the full SHA
    c22b78b View commit details
    Browse the repository at this point in the history
  4. fix(usage): Make dont_collapse_args_in_usage the default

    The setting was added to resolve clap-rs#769.  The reason it was optional is out
    of concern for applications with a lot of positional arguments.  I think
    those cases are rare enough that we should just push people to override
    the usage.  Positional arguments are generally important enough, even if
    optional, to show.
    
    As a side effect, this fixed some bugs with
    `dont_collapse_args_in_usage` where it would repeat an argument in a
    smart usage.
    
    As a side effect, smart usage now shows `--` when it should
    epage committed Aug 30, 2022
    Copy the full SHA
    02d27b5 View commit details
    Browse the repository at this point in the history