Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 dev #1182

Merged
merged 4 commits into from
Feb 14, 2018
Merged

V3 dev #1182

merged 4 commits into from
Feb 14, 2018

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Feb 13, 2018 •
edited

@kbknapp
imp(Bash Completions): instead of completing a generic option name, a…
79a2104 
…ll bash completions fall back to file completions UNLESS Arg::possible_values was used
@kbknapp
tests(Bash Completions): updates the bash completions to the new file…
cdfdbff 
… completion fallback
@kbknapp
imp(Deps): doesnt compile ansi_term on Windows since its not used
6971624 
Before this commit, ansi_term was compiled anytime the `color` feature
was used. However, on Windows the `color` feature is ignored. Even so
ansi_term was compiled, and just not used. This commit fixes that by
only compiling ansi_term on non-Windows targets. Thanks to @retep998 for
the gudiance.

Closes #1155
@kbknapp
style: removes unused imports
e0b891d
@mention-bot
Copy link

@kbknapp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer.

@kbknapp kbknapp merged commit bd08e73 into v3-master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kbknapp @mention-bot