Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(help): Don't commit to '--help' that doesn't work #3169

Merged
merged 1 commit into from
Dec 13, 2021
Merged

fix(help): Don't commit to '--help' that doesn't work #3169

merged 1 commit into from
Dec 13, 2021

Commits on Dec 13, 2021

  1. fix(help): Don't commit to '--help' that doesn't work 

    We have two ways of fixing this
- Making `--help` work
- Don't put `--help` in the help output

For now, I went with the latter.  I tried to make it clear what the
actual requirement is so we can pivot if needed.

Fixes clap-rs#2892

This happens to also fix the interaction of `DisableHelpFlag` with the
help subcommand and complcations.  I've added a test to help catch if we
break this by changing how we fixed the original issue.

Fixes clap-rs#2724

These issues were reported against clap3.  I've not tried to reproduce
these in clap2 to see if they should show up in the release notes.
    @epage
    epage committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    19ed78c View commit details
    Browse the repository at this point in the history