New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(derive): Allow users to opt-in to ValueParser
#3742
Merged
Merged
Commits on May 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1446be8 - Browse repository at this point
Copy the full SHA 1446be8View commit details -
refactor(derive): Don't alias arg matches
Right now, the aliasing is safe (the compiler says so!) but we're going to be switching to a `&mut` and need to ensure we don't alias.
Configuration menu - View commit details
-
Copy full SHA for 5806e16 - Browse repository at this point
Copy the full SHA 5806e16View commit details
Commits on May 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b817c2d - Browse repository at this point
Copy the full SHA b817c2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18f2950 - Browse repository at this point
Copy the full SHA 18f2950View commit details -
Configuration menu - View commit details
-
Copy full SHA for d61552a - Browse repository at this point
Copy the full SHA d61552aView commit details -
perf(derive): Reuse allocations for external subcommands
In case the `ArgMatches` is cloned, this forces a constraint that the underlying type impls `Clone` but that should be safe as we only support `String` and `OsString`.
Configuration menu - View commit details
-
Copy full SHA for 0628d04 - Browse repository at this point
Copy the full SHA 0628d04View commit details -
feat(derive): Allow users to opt-in to
ValueParser
For clap 3, its opt-in as a precaution against breaking compatibility in some weird cases. This does require the types to implement `Clone`. Fixes clap-rs#3734 Fixes clap-rs#3496 Fixes clap-rs#3589
Configuration menu - View commit details
-
Copy full SHA for b52c7f1 - Browse repository at this point
Copy the full SHA b52c7f1View commit details -
perf(derive): Reuse allocations where possible
Only bothered to implement this for `value_parser` cases as `parse` cases are going to be considered deprecated.
Configuration menu - View commit details
-
Copy full SHA for 7845e60 - Browse repository at this point
Copy the full SHA 7845e60View commit details
Commits on May 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a35df14 - Browse repository at this point
Copy the full SHA a35df14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fba615 - Browse repository at this point
Copy the full SHA 2fba615View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b4ea8e - Browse repository at this point
Copy the full SHA 5b4ea8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 852a1b1 - Browse repository at this point
Copy the full SHA 852a1b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e23800e - Browse repository at this point
Copy the full SHA e23800eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.