New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser): Make behavior more consistent #3765
Commits on May 26, 2022
-
refactor(parser): Consolidate help/version handling
This is a step towards user-visible actions
Configuration menu - View commit details
-
Copy full SHA for 8683200 - Browse repository at this point
Copy the full SHA 8683200View commit details -
fix(parser): Pass the intended flag to the action
Inferred flags can make it hard for a future action to trigger behavior off of the selected alias, like we might want to do for negations, so we are now translating to the intended arg. This will also help for debugging.
Configuration menu - View commit details
-
Copy full SHA for 28cb71c - Browse repository at this point
Copy the full SHA 28cb71cView commit details
Commits on May 27, 2022
-
refactor(parser)!: Consolidate group/occurrence logic
We were independently starting occurrences and starting value groups. Now we do them at the same time. COMPATIBILITY: This changes us from counting occurrences per positional when using `multiple_values` to one occurrence. This is user visible and tests were written against it but it goes against the documentation and doesn't quite make sense.
Configuration menu - View commit details
-
Copy full SHA for 9805fda - Browse repository at this point
Copy the full SHA 9805fdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for ccc809a - Browse repository at this point
Copy the full SHA ccc809aView commit details -
fix(parser): Always use delimiter on defaults/env
Doesn't make sense to respect how the command line ended
Configuration menu - View commit details
-
Copy full SHA for 302bf63 - Browse repository at this point
Copy the full SHA 302bf63View commit details -
refactor(parser): Be more explicit in default_missing_values
I wrote these tests expecting to highlight a bug but it turns out things were structured just right to not exhibit it. The fact that the code looks like its broken is a problem, so I restructured it (put it first, changed the source) so it doesn't look suspicious anymore.
Configuration menu - View commit details
-
Copy full SHA for c72f03e - Browse repository at this point
Copy the full SHA c72f03eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e268dbf - Browse repository at this point
Copy the full SHA e268dbfView commit details -
fix(parser): Always end on required delimited arg
Before, if we were in trailing values that aren't delimite, we wouldn't respect this flag and end processing of the value, now we do. This also has a slight perf benefit of us only splitting the value if the delimiter is present. We checked for the delimiter anyways, so doing it first removes a slight bit of work. I also feel this helps clarify the intended behavior and ooches us towards a unified code path for actions.
Configuration menu - View commit details
-
Copy full SHA for 9f46867 - Browse repository at this point
Copy the full SHA 9f46867View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac8320d - Browse repository at this point
Copy the full SHA ac8320dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a409be - Browse repository at this point
Copy the full SHA 2a409beView commit details -
refactor(parser): Clarify intent for defaults/envs
Especially important is not inferring intent from occurrences as hopefully that will change with the introduction of actions.
Configuration menu - View commit details
-
Copy full SHA for 8f16f2e - Browse repository at this point
Copy the full SHA 8f16f2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e41a65d - Browse repository at this point
Copy the full SHA e41a65dView commit details