Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(derive): Switch default action/parser for unstable-v4 #3827

Merged
merged 5 commits into from Jun 14, 2022
Merged

fix(derive): Switch default action/parser for unstable-v4 #3827

merged 5 commits into from Jun 14, 2022

Commits on Jun 13, 2022

  1. test(derive): Update another case to new approach

    @epage
    epage committed Jun 13, 2022
    Copy the full SHA
    483b64e View commit details
    Browse the repository at this point in the history

  2. test: Don't run legacy tests with v4 behavior

    @epage
    epage committed Jun 13, 2022
    Copy the full SHA
    b7668e8 View commit details
    Browse the repository at this point in the history

  3. test(derive): No longer supporting some wrapped types 

    With the new `ArgMatches`, we need to know what the inner type is.

Unfortunately, clap-rs#3142 didn't list use cases for this.  We dropped the
`Option` alias changing `T` but we still have a `Result` in there that
is aliased.

One potential workaround if people need it is if we add an attribute to
specify the `get_many::<T>` type.  This would also help with
`ArgAction::Count` to support more data types.
    @epage
    epage committed Jun 13, 2022
    Copy the full SHA
    3686244 View commit details
    Browse the repository at this point in the history

  4. test(derive): Allow specializing tests for unstable-v4

    @epage
    epage committed Jun 13, 2022
    Copy the full SHA
    cc76d28 View commit details
    Browse the repository at this point in the history

  5. fix(derive): Switch default actions/parsers for unstable-v4

    @epage
    epage committed Jun 13, 2022
    Copy the full SHA
    0a529c1 View commit details
    Browse the repository at this point in the history