Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Use value parsers for external subcommands #3990

Merged
merged 2 commits into from Jul 25, 2022
Merged

fix!: Use value parsers for external subcommands #3990

merged 2 commits into from Jul 25, 2022

Commits on Jul 25, 2022

  1. fix!: Remove PartialEq from Command 

    This gives us more implementation flexibility
    @epage
    epage committed Jul 25, 2022
    Copy the full SHA
    475a0fc View commit details
    Browse the repository at this point in the history

  2. fix!: Use value parsers for external subcommands 

    This changes the default type as well to encourage preserving the full
information for shelling out.  If people need UTF-8, then they can
change the value parser.

Fixes clap-rs#3733
    @epage
    epage committed Jul 25, 2022
    Copy the full SHA
    8ea1e2d View commit details
    Browse the repository at this point in the history