fix: Misc clean up in prep for #2688 #3999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `number_of_values` being per-occurrence now, its doesn't make sense for `number_of_values(0)` to set `takes_value(true)` or for `number_of_values(1)` to set `multiple_values(true)`. In addition, an assert is made if the user works around this
Rendering of usage is not in a critical path, so should be more worried about binary size than performance. That only leaves avoiding coloring spaces. That shouldn't be a problem, so let's make the binary smaller.
|
btw according to cargo-bloat, this saved us 2k in .text I ran $ cargo bloat --release --example cargo-example --features cargo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting this out and getting it merged so I can more easily iterate on different approaches to resolving #2688.