Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Rely on default_missing_value for flag actions #4000

Merged
merged 2 commits into from Jul 28, 2022
Merged

fix(parser): Rely on default_missing_value for flag actions #4000

merged 2 commits into from Jul 28, 2022

Commits on Jul 28, 2022

  1. fix: Simplify flag parsing 

    Multiple values can only happen from env variables when configured by
the user, so let's not go out of our way to deal with it.
    @epage
    epage committed Jul 28, 2022
    Copy the full SHA
    f76a867 View commit details
    Browse the repository at this point in the history

  2. fix(parser): Rely on default_missing_value for flag actions 

    In the short term, this just provides a back door to custom actions.
Longer term, we can explore a `SetConst` action that relies on this
behavior.  Really, `SetTrue` and `SetFalse` are shortcuts for such an
action but shortcuts can be helpful for usability.

Apparently, this also reduced `.text` size by 1k
    @epage
    epage committed Jul 28, 2022
    Copy the full SHA
    8e20782 View commit details
    Browse the repository at this point in the history