Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser)!: Split on value delimiter after validating num_args #4025

Merged
merged 1 commit into from Aug 4, 2022
Merged

fix(parser)!: Split on value delimiter after validating num_args #4025

merged 1 commit into from Aug 4, 2022

Commits on Aug 4, 2022

  1. fix(parser)!: Split on value delimiter after validating num_args 

    This will allow `num_args(0..=1).value_delimiter(',')` to work properly.

This hacks in support for `require_value_delimiter` until we can remove
it.

This no longer recognzes value terminators in delimited lists.

It looks like there is a bug with recognizing value terminators in
positionals arguments.  We'll need to dig into that more.
    @epage
    epage committed Aug 4, 2022
    Copy the full SHA
    6b3a5bd View commit details
    Browse the repository at this point in the history