Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Require/default conditional APIs are more explicit #4084

Merged
merged 5 commits into from Aug 16, 2022
Merged

fix!: Require/default conditional APIs are more explicit #4084

merged 5 commits into from Aug 16, 2022

Commits on Aug 15, 2022

  1. refactor: Pull out distinct String type

    @epage
    epage committed Aug 15, 2022
    Copy the full SHA
    2061a96 View commit details
    Browse the repository at this point in the history

  2. refactor: Make ArgPredicate non-copyable 

    This is prep for holding an owned type
    @epage
    epage committed Aug 15, 2022
    Copy the full SHA
    3c2635a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. fix: Allow OsStr for some required_if_eq calls

    @epage
    epage committed Aug 16, 2022
    Copy the full SHA
    30d4ef4 View commit details
    Browse the repository at this point in the history

  2. refactor: Remove lifetime from ArgPredicate

    @epage
    epage committed Aug 16, 2022
    Copy the full SHA
    17a07ab View commit details
    Browse the repository at this point in the history

  3. fix!: Require/default conditional APIs are more explicit 

    This helps with
- API cleanup by not having ambigious `None`, see clap-rs#950
- Removes ambiguity with `None` when using owned/borrowed types for
  clap-rs#1041
    @epage
    epage committed Aug 16, 2022
    Copy the full SHA
    09288b4 View commit details
    Browse the repository at this point in the history