Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(error): Allow custmizing formatting #4111

Merged
merged 4 commits into from Aug 24, 2022
Merged

perf(error): Allow custmizing formatting #4111

merged 4 commits into from Aug 24, 2022

Commits on Aug 24, 2022

  1. refactor(error): Delay colorizing until the end 

    This is prep for creating a formatter trait to select alternative
implementations for errors.
    @epage
    epage committed Aug 24, 2022
    Copy the full SHA
    3672663 View commit details
    Browse the repository at this point in the history

  2. refactor(error): Switch Vec to FlatMap 

    Looks like this dropped 2 KiB
    @epage
    epage committed Aug 24, 2022
    Copy the full SHA
    ba5a4bc View commit details
    Browse the repository at this point in the history

  3. feat(error): Expose context lookup

    @epage
    epage committed Aug 24, 2022
    Copy the full SHA
    d16a531 View commit details
    Browse the repository at this point in the history

  4. perf(error): Allow custmizing formatting 

    For now, there isn't much a custom implementation can do.

Going from `Rich` to `Null` drops about 6 KiB from the binary

This is a part of clap-rs#1365 and clap-rs#1384
    @epage
    epage committed Aug 24, 2022
    Copy the full SHA
    ef5f9f9 View commit details
    Browse the repository at this point in the history