Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Improve required error messages #4148

Merged
merged 13 commits into from Aug 30, 2022
Merged

fix(parser): Improve required error messages #4148

merged 13 commits into from Aug 30, 2022

Commits on Aug 29, 2022

  1. refactor(parser): Consolidate presence check

    @epage
    epage committed Aug 29, 2022
    Copy the full SHA
    dacc8ff View commit details
    Browse the repository at this point in the history

  2. refactor(parser): Flatten required_unless logic

    @epage
    epage committed Aug 29, 2022
    Copy the full SHA
    3c466c6 View commit details
    Browse the repository at this point in the history

  3. refactor(parser): Prefer explicit for loops

    @epage
    epage committed Aug 29, 2022
    Copy the full SHA
    14d910d View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. fix(parser): Show all required errors at once 

    This also has the side effect of always using the "smart usage" which is
why the tests changed.
    @epage
    epage committed Aug 30, 2022
    Copy the full SHA
    0c9b9d7 View commit details
    Browse the repository at this point in the history

  2. refactor(parser): Consolidate the loops

    @epage
    epage committed Aug 30, 2022
    Copy the full SHA
    26ea3e3 View commit details
    Browse the repository at this point in the history

  3. refactor(usage): Split out group processing

    @epage
    epage committed Aug 30, 2022
    Copy the full SHA
    ecb632f View commit details
    Browse the repository at this point in the history

  4. refactor(usage): Pull out duplicate check

    @epage
    epage committed Aug 30, 2022
    Copy the full SHA
    3b17f7f View commit details
    Browse the repository at this point in the history

  5. refactor(usage): Make duplicate check more resilient

    @epage
    epage committed Aug 30, 2022
    Copy the full SHA
    8556951 View commit details
    Browse the repository at this point in the history

  6. refactor(usage): Consolidate required bookkeeping

    @epage
    epage committed Aug 30, 2022
    Copy the full SHA
    09031fb View commit details
    Browse the repository at this point in the history

  7. refactor(usage): Make last check clearer

    @epage
    epage committed Aug 30, 2022
    Copy the full SHA
    66957f8 View commit details
    Browse the repository at this point in the history

  8. perF(usage): Defer de-duplicating to later 

    This should drop code size
    @epage
    epage committed Aug 30, 2022
    Copy the full SHA
    619b1fb View commit details
    Browse the repository at this point in the history

  9. refactor(parser): Hoist check into iteration

    @epage
    epage committed Aug 30, 2022
    Copy the full SHA
    2388ace View commit details
    Browse the repository at this point in the history

  10. fix(parser): Require earlier, not-present positionals

    @epage
    epage committed Aug 30, 2022
    Copy the full SHA
    8da1f08 View commit details
    Browse the repository at this point in the history