Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(derive): Prepare for builder attributes #4179

Merged
merged 9 commits into from Sep 2, 2022
Merged

refactor(derive): Prepare for builder attributes #4179

merged 9 commits into from Sep 2, 2022

Commits on Sep 2, 2022

  1. refactor(derive): Make Sp copyable

    @epage
    epage committed Sep 2, 2022
    Copy the full SHA
    c56277c View commit details
    Browse the repository at this point in the history

  2. refactor(derive): Determine an Item's Kind first 

    This will allow the attribute processing to change based on the kind
    @epage
    epage committed Sep 2, 2022
    Copy the full SHA
    11ffcf9 View commit details
    Browse the repository at this point in the history

  3. fix(derive): Improve Kind conflict errors 

    This makes it better scale for the future
    @epage
    epage committed Sep 2, 2022
    Copy the full SHA
    edce5c2 View commit details
    Browse the repository at this point in the history

  4. fix(derive): Provide deprecations for bald action/value_parser 

    These will be going away, so we should tell the user.

This is mostly a test bed for our new deprecation plumbing.
    @epage
    epage committed Sep 2, 2022
    Copy the full SHA
    7eaa226 View commit details
    Browse the repository at this point in the history

  5. Revert "fix(derive): Remove structopt attribute support" 

    This reverts commit 521a012.
    @epage
    epage committed Sep 2, 2022
    Copy the full SHA
    7b0c76d View commit details
    Browse the repository at this point in the history

  6. fix(derive): Report deprecations for structopt attributes 

    This is more of a test bed for adding new attributes and deprecating
clap ones.
    @epage
    epage committed Sep 2, 2022
    Copy the full SHA
    0ae119f View commit details
    Browse the repository at this point in the history

  7. refactor(derive): Track the item's Kind

    @epage
    epage committed Sep 2, 2022
    Copy the full SHA
    59a4578 View commit details
    Browse the repository at this point in the history

  8. refactor(derive): Generalize Kind based error checks

    @epage
    epage committed Sep 2, 2022
    Copy the full SHA
    97ce0c4 View commit details
    Browse the repository at this point in the history

  9. refactor(derive): Further generalize kind errors

    @epage
    epage committed Sep 2, 2022
    Copy the full SHA
    dbdd449 View commit details
    Browse the repository at this point in the history