Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Misc fixes found when optimizing code size #4222

Merged
merged 8 commits into from Sep 16, 2022
Merged

fix: Misc fixes found when optimizing code size #4222

merged 8 commits into from Sep 16, 2022

Commits on Sep 16, 2022

  1. fix(derive): Read CARGO_PKG_NAME at runtime 

    This was broken in clap-rs#4168
    @epage
    epage committed Sep 16, 2022
    Copy the full SHA
    417f1a9 View commit details
    Browse the repository at this point in the history

  2. fix(derive): Remove next_help_heading isolation 

    Originally, I saw the ideal as the parent command being isolated from
`#[clap(flatte)]` especially after all of the doc comment
leakage issues.  We scaled that back to just `next_help_heading` because
of the issues with settling on a policy and maintenance to cover
everything.  When doing `next_display_order`, we decided it would mess
things up too much to isolate it.

With clap-rs#1807, we instead have been moving towards setting
`#[command(next_help_heading)]` anywhere, we just need to finish working
out how it should work.
    @epage
    epage committed Sep 16, 2022
    Copy the full SHA
    14c6ce0 View commit details
    Browse the repository at this point in the history

  3. perf: Misc simplifications for code size 

    This dropped a fraction of a KiB but it will at least not cause people
to ask if it'd help to simplify in the future.
    @epage
    epage committed Sep 16, 2022
    Copy the full SHA
    dbf2c86 View commit details
    Browse the repository at this point in the history

  4. fix: Generalize mut_arg, like mut_subcommand 

    This makes us accept `str` and not do any allocations at the cost of
panicing if unsupported which I think fits our overall story in trying
to catch development-time errors.
    @epage
    epage committed Sep 16, 2022
    Copy the full SHA
    acb0fb7 View commit details
    Browse the repository at this point in the history

  5. docs(tutorial): Provide better default_value_t example

    @epage
    epage committed Sep 16, 2022
    Copy the full SHA
    3cadb8f View commit details
    Browse the repository at this point in the history

  6. refactor: Simplify help subtree creation

    @epage
    epage committed Sep 16, 2022
    Copy the full SHA
    4869c43 View commit details
    Browse the repository at this point in the history

  7. refactor(parser): Don't throwaway work

    @epage
    epage committed Sep 16, 2022
    Copy the full SHA
    af9e1b9 View commit details
    Browse the repository at this point in the history

  8. refactor(parser): Reduce work when validating args

    @epage
    epage committed Sep 16, 2022
    Copy the full SHA
    86b2fe5 View commit details
    Browse the repository at this point in the history