Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow turning off error-context, auto-help, and auto-usage #4236

Merged
merged 11 commits into from Sep 19, 2022
Merged

feat: Allow turning off error-context, auto-help, and auto-usage #4236

merged 11 commits into from Sep 19, 2022

Commits on Sep 19, 2022

  1. feat(error): Provide abstraction for default formatter

    @epage
    epage committed Sep 19, 2022
    Copy the full SHA
    ba9e6d0 View commit details
    Browse the repository at this point in the history

  2. fix(error): Provide a no-context alternative to RichFormatter

    @epage
    epage committed Sep 19, 2022
    Copy the full SHA
    b4788d5 View commit details
    Browse the repository at this point in the history

  3. feat(error): Break out error-context feature flag 

    This is a cheap pass at creating this to allow cutting out the cost of
rich error information / programmatic error information.

This cuts about 20 KiB off of the binary.

There is more we could cut out, like collecting of used arguments for
the usage, but I want to keep the conditionals simple.
    @epage
    epage committed Sep 19, 2022
    Copy the full SHA
    2d83a7b View commit details
    Browse the repository at this point in the history

  4. perf(help): Reduce colorless code size 

    This takes off another 14 KiB when color us not used.  My hope is that
we'll be able to switch away from `termcolor` to a term styling crate
that will make this work in the color case as well.
    @epage
    epage committed Sep 19, 2022
    Copy the full SHA
    e75da2f View commit details
    Browse the repository at this point in the history

  5. refactor(help): Split out help templates

    @epage
    epage committed Sep 19, 2022
    Copy the full SHA
    9036d3f View commit details
    Browse the repository at this point in the history

  6. refactor(help): Move near use

    @epage
    epage committed Sep 19, 2022
    Copy the full SHA
    6ea5d46 View commit details
    Browse the repository at this point in the history

  7. feat(help): Break out help feature flag 

    This removes auto-generated help, saving about 50 KiB.
    @epage
    epage committed Sep 19, 2022
    Copy the full SHA
    7a5dad8 View commit details
    Browse the repository at this point in the history

  8. refactor(help): Make usage optional

    @epage
    epage committed Sep 19, 2022
    Copy the full SHA
    553a93e View commit details
    Browse the repository at this point in the history

  9. refactor(parser): Clarify argument

    @epage
    epage committed Sep 19, 2022
    Copy the full SHA
    80f616a View commit details
    Browse the repository at this point in the history

  10. feat(help): 'usage' feature flag for auto-genned usage

    @epage
    epage committed Sep 19, 2022
    Copy the full SHA
    bfa365a View commit details
    Browse the repository at this point in the history

  11. perf(help): Remove more from usage feature 

    Quality of error-context goes down with this.
    @epage
    epage committed Sep 19, 2022
    Copy the full SHA
    745fa99 View commit details
    Browse the repository at this point in the history