Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove unstable-replace feature flag #4805

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

epage
Copy link
Member

@epage epage commented Mar 28, 2023

This has been implemented for 3 years without much traction for finishing it up.

The subcommand use case can be worked around by creating Commands that just include the relevant logic, very similar to the default subcommand examples in git / git-derive.

Using this for flags is covered by #4793.

Without unstable-replace being enabled, this still cut 5 KiB from cargo bloat --release --example git.

Closes #2836
Closes #2011

This has been implemented for 3 years without much traction for
finishing it up.

The subcommand use case can be worked around by creating `Command`s that
just include the relevant logic, very similar to the default subcommand
examples in `git` / `git-derive`.

Using this for flags is covered by clap-rs#4793.

Without `unstable-replace` being enabled, this still cut 5 KiB from
`cargo bloat --release --example git`.

Closes clap-rs#2836
Closes clap-rs#2011
@epage epage merged commit 4ed6ddb into clap-rs:master Mar 28, 2023
@epage epage deleted the replace branch March 28, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant