Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps):Remove cargo audit errors via cargo update #5420

Closed
wants to merge 1 commit into from

Conversation

Pi-Cla
Copy link
Contributor

@Pi-Cla Pi-Cla commented Mar 24, 2024

It seems that all of the errors are coming from various transitive dependencies in older versions of nushell (which clap_complete_nushell depends on)

Some noteworthy ones include RUSTSEC-2024-0019 and RUSTSEC-2023-0044

See cargo-audit-clap.txt for the full list

It seems that all of the errors are coming from
various transitive dependencies in older versions
of nushell (which clap_complete_nushell depends on)
@epage
Copy link
Member

epage commented Mar 25, 2024

Is there a reason this is of concern? What is in our lockfile does not affect those who use clap. I generally like to keep Cargo.toml in sync with Cargo.lock as we aren't verifying the minimum bounds of our version requirements and I tend to keep version requirements low to avoid churn. Blanket upgrades run counter to these.

@Pi-Cla
Copy link
Contributor Author

Pi-Cla commented Mar 25, 2024

Point taken

@Pi-Cla Pi-Cla closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants