fix(complete): Don't panic on broken pipe #5453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the completion is piped to another command, for example into `less`, and that program stops before reading everything, the write fails and the program panics. Make it exit gracefully instead.
epage
reviewed
Apr 15, 2024
Comment on lines
+5
to
+11
| Err(err) if err.kind() == std::io::ErrorKind::BrokenPipe => { | ||
| // Is there a better exit code for this? | ||
| std::process::exit(1); | ||
| } | ||
| Err(err) => { | ||
| panic!("Failed to write to generated file: {0}", err); | ||
| } |
There was a problem hiding this comment.
Neither case should panic but we should report this error up. Please open an issue on this for us to track for our next breaking change.
There was a problem hiding this comment.
Opened #5457.
Should I close this?
There was a problem hiding this comment.
The solution will change and some time past, so sure.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the completion is piped to another command, for example into
less, and that program stops before reading everything, the write fails and the program panics. Make it exit gracefully instead.