Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure: Add Storage Accounts file detectors #232

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Azure: Add Storage Accounts file detectors #232

wants to merge 3 commits into from

Conversation

BzSpi
Copy link
Contributor

@BzSpi BzSpi commented Jan 6, 2021

Relates to #206

@BzSpi BzSpi added enhancement Enhancement of existing (templating or detectors) detectors About nex or existing detectors labels Jan 6, 2021
@BzSpi BzSpi added this to the v1.1.0 milestone Jan 6, 2021
@BzSpi BzSpi added this to In progress in Claranet via automation Jan 6, 2021
@BzSpi BzSpi self-assigned this Jan 6, 2021
Claranet automation moved this from In progress to Review in progress Jan 6, 2021
@BzSpi BzSpi force-pushed the azure_storage_file_premium branch from 98716c2 to 5ad9af6 Compare January 7, 2021 08:23
@BzSpi BzSpi requested a review from Shr3ps January 7, 2021 08:24
@xp-1000 xp-1000 modified the milestones: v1.1.0, v1.2.0 Jan 7, 2021
@xp-1000 xp-1000 modified the milestones: v1.2.0, v1.3.0 Feb 22, 2021
@xp-1000 xp-1000 removed this from the v1.3.0 milestone Mar 19, 2021
@Shr3ps Shr3ps force-pushed the azure_storage_file_standard branch 2 times, most recently from 960102c to 65eaf23 Compare May 6, 2021 13:25
@BzSpi BzSpi force-pushed the azure_storage_file_premium branch from 5ad9af6 to 4fe8eb7 Compare July 6, 2022 08:12
@BzSpi BzSpi changed the base branch from azure_storage_file_standard to master July 6, 2022 08:57
@BzSpi BzSpi mentioned this pull request Jul 6, 2022
Closed
@BzSpi BzSpi force-pushed the azure_storage_file_premium branch from 4fe8eb7 to 730ad0b Compare July 6, 2022 08:59
@BzSpi BzSpi force-pushed the azure_storage_file_premium branch from 730ad0b to b30d545 Compare July 6, 2022 08:59
@BzSpi
Copy link
Contributor Author

BzSpi commented Jul 6, 2022

I've made the following remarks to splunk regarding their implementation:

I took a look at the metrics and found some implementaion that does not fit well

  • The file share name dimension is sometimes named "FileShare" (metrics Transactions, Egress, Ingress) and sometimes "fileshare" (metrics FileCapacity, FileShareCapacityQuota, FileShareSnapshotCount...). Comparing the metrics is only possible by doing dimensions renaming in signlaflow
  • The storage account tags dimensions are missing for some metrics (FileShareCapacityQuota, FileShareSnapshotCount...)
  • The dimension azure_resource_name is missing on some metrics

We achieved to have workarounds for "file share" dimension casing and lack of azure_resource_name dimensions prevent using the metrics in production.

@BzSpi BzSpi force-pushed the azure_storage_file_premium branch from b30d545 to 7a43fa6 Compare July 6, 2022 09:16
@BzSpi BzSpi force-pushed the azure_storage_file_premium branch from 7a43fa6 to 008e55d Compare July 6, 2022 09:20
@BzSpi BzSpi changed the title Azure: Add Storage Accounts premium file detectors Azure: Add Storage Accounts file detectors Jul 8, 2022
@BzSpi
Copy link
Contributor Author

BzSpi commented Aug 26, 2022

Set the non working detectors (those without filtering) to disabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shr3ps Shr3ps Awaiting requested review from Shr3ps Shr3ps is a code owner

@cvauvarin cvauvarin Awaiting requested review from cvauvarin cvauvarin will be requested when the pull request is marked ready for review cvauvarin is a code owner

@haedri haedri Awaiting requested review from haedri haedri will be requested when the pull request is marked ready for review haedri is a code owner

@JMHAUTBOIS-Claranet JMHAUTBOIS-Claranet Awaiting requested review from JMHAUTBOIS-Claranet JMHAUTBOIS-Claranet will be requested when the pull request is marked ready for review JMHAUTBOIS-Claranet is a code owner

@pdecat pdecat Awaiting requested review from pdecat pdecat will be requested when the pull request is marked ready for review pdecat is a code owner

@tchernomax tchernomax Awaiting requested review from tchernomax tchernomax will be requested when the pull request is marked ready for review tchernomax is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@BzSpi BzSpi

Labels
detectors About nex or existing detectors enhancement Enhancement of existing (templating or detectors)
Projects
Claranet
Review in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BzSpi @Shr3ps @xp-1000