Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration azure event hub #262

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Integration azure event hub #262

wants to merge 1 commit into from

Conversation

nicolasvion
Copy link
Contributor

  • Fixes based on a basic customer's case
  • Microsoft.EventHub/clusters => Microsoft.EventHub/namespaces
  • Default warning values at 5% (0 seems not relevant)

@nicolasvion nicolasvion force-pushed the integration_azure-event-hub branch 3 times, most recently from 18345c4 to 38312f0 Compare March 19, 2021 11:36
@Shr3ps
Copy link
Member

Shr3ps commented Mar 24, 2021

Can you split this in 2 PRs? maybe one for the real fixes on namespace, another for the temporary one for the tags bug.

@xp-1000 xp-1000 added detectors About nex or existing detectors new feature Request for new feature labels Mar 26, 2021
@xp-1000 xp-1000 added this to In progress in Claranet via automation Mar 26, 2021
@xp-1000 xp-1000 added this to the v1.3.0 milestone Mar 26, 2021
@Shr3ps Shr3ps mentioned this pull request Apr 14, 2021
Merged
@xp-1000
Copy link
Contributor

xp-1000 commented Aug 9, 2021

without answer from the author I convert his PR to draft

@xp-1000 xp-1000 marked this pull request as draft August 9, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BzSpi BzSpi Awaiting requested review from BzSpi BzSpi is a code owner

@cvauvarin cvauvarin Awaiting requested review from cvauvarin cvauvarin is a code owner

@Shr3ps Shr3ps Awaiting requested review from Shr3ps Shr3ps is a code owner

@xp-1000 xp-1000 Awaiting requested review from xp-1000

@haedri haedri Awaiting requested review from haedri haedri will be requested when the pull request is marked ready for review haedri is a code owner

@JMHAUTBOIS-Claranet JMHAUTBOIS-Claranet Awaiting requested review from JMHAUTBOIS-Claranet JMHAUTBOIS-Claranet will be requested when the pull request is marked ready for review JMHAUTBOIS-Claranet is a code owner

@pdecat pdecat Awaiting requested review from pdecat pdecat will be requested when the pull request is marked ready for review pdecat is a code owner

@tchernomax tchernomax Awaiting requested review from tchernomax tchernomax will be requested when the pull request is marked ready for review tchernomax is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
detectors About nex or existing detectors new feature Request for new feature
Projects
Claranet
In progress
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolasvion @Shr3ps @xp-1000