Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease cache_hit_rate criticity #297

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Decrease cache_hit_rate criticity #297

wants to merge 3 commits into from

Conversation

BenjyOC
Copy link
Contributor

@BenjyOC BenjyOC commented Jul 2, 2021

I updated the cache_hit_rate detector criticity.

xp-1000
xp-1000 suggested changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@xp-1000 xp-1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say to use minor/warning combination because this remains a performance related issue https://github.com/claranet/terraform-signalfx-detectors/wiki/Notifications-binding#minor

@BenjyOC
Copy link
Contributor Author

BenjyOC commented Jul 2, 2021

@xp-1000 Why not. A low hit cache ratio can generate poor http application performance but not because of varnish service. However, it can be useful to alert customer about it with minor/warning severity. I'll update the code.
Thx !

@xp-1000
Copy link
Contributor

xp-1000 commented Jul 20, 2021

Hello @BenjyOC, any news ?

I would like to release a new version, just want to check if I can include this

@xp-1000 xp-1000 marked this pull request as draft October 22, 2021 09:23
@xp-1000
Copy link
Contributor

xp-1000 commented Oct 22, 2021

converted as draft waiting for requested changes applied

@pdecat pdecat added the detectors About nex or existing detectors label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xp-1000 xp-1000 xp-1000 requested changes

@BzSpi BzSpi Awaiting requested review from BzSpi BzSpi is a code owner

@cvauvarin cvauvarin Awaiting requested review from cvauvarin cvauvarin is a code owner

@Shr3ps Shr3ps Awaiting requested review from Shr3ps Shr3ps is a code owner

@haedri haedri Awaiting requested review from haedri haedri will be requested when the pull request is marked ready for review haedri is a code owner

@JMHAUTBOIS-Claranet JMHAUTBOIS-Claranet Awaiting requested review from JMHAUTBOIS-Claranet JMHAUTBOIS-Claranet will be requested when the pull request is marked ready for review JMHAUTBOIS-Claranet is a code owner

@pdecat pdecat Awaiting requested review from pdecat pdecat will be requested when the pull request is marked ready for review pdecat is a code owner

@tchernomax tchernomax Awaiting requested review from tchernomax tchernomax will be requested when the pull request is marked ready for review tchernomax is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
detectors About nex or existing detectors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BenjyOC @xp-1000 @pdecat