-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow boundary on role #68
Open
nmamn
wants to merge
4
commits into
master
Choose a base branch
from
allow_boundary_on_role
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmamn
requested review from
BzSpi,
cvauvarin,
JMHAUTBOIS-Claranet,
pdecat,
Shr3ps and
tchernomax
as code owners
September 8, 2023 09:45
pdecat
reviewed
Sep 8, 2023
name = "SignalFxIntegration${var.suffix == "" ? "" : "-${title(var.suffix)}"}" | ||
description = "SignalFx integration to read out data and send it to SignalFx's AWS account" | ||
assume_role_policy = data.aws_iam_policy_document.sfx_policy_doc.json | ||
permissions_boundary = var.sfx_role_permissions_boundary != null ? var.sfx_role_permissions_boundary : null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
permissions_boundary = var.sfx_role_permissions_boundary != null ? var.sfx_role_permissions_boundary : null | |
permissions_boundary = var.sfx_role_permissions_boundary |
pdecat
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment, but LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a client's account, we are not IAM Admins, so we need to attach a boundary policy to the role created by the module, in order to limit what we can do.
This PR is there to permit this feature, and should not change anything when there is no boundary policy used.