-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add py as requirement for test #96
Conversation
workaround for issue https://gitlab.com/uweschmitt/pytest-regtest/-/issues/19 Signed-off-by: Gerardo Roa Dabike <gerardo.roa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this work around @groadabike 👍
If and when the issue with pytest-regtest
gets resolved I'll update things.
setup.cfg
Outdated
@@ -65,6 +65,7 @@ tests = | |||
pytest-mpl | |||
pytest-regtest | |||
yamllint | |||
py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overly pedantic but the list is alphabetical I think to aid reading (well it helps me at least!), so I'd have slotted this in between pre-commit
and pytest
.
workaround for issue https://gitlab.com/uweschmitt/pytest-regtest/-/issues/19 Signed-off-by: Gerardo Roa Dabike <gerardo.roa@gmail.com>
…t' into 95-add-py-as-requirement-for-test
As requested, I changed the order of the requirements. Little by little, getting there with the best practices |
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 84.30% 83.85% -0.45%
==========================================
Files 30 30
Lines 3370 3370
==========================================
- Hits 2841 2826 -15
- Misses 529 544 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
workaround for issue https://gitlab.com/uweschmitt/pytest-regtest/-/issues/19
Signed-off-by: Gerardo Roa Dabike gerardo.roa@gmail.com