Feature/add in multiple ranges #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 16, 2017 16:26
…nges just like with multipleDate Click anywhere on a range to edit, while editing click on the start date to remove. Still requires keyboard support and header cleanup. (will combine current multi-date and range functionality into one)
header click events work correctly now based upon multidate and withRange
akado117
force-pushed
the
feature/AddInMultipleRanges
branch
from
82b6fa6
to
8f02af9
Compare
added 2 commits
November 17, 2017 14:10
…what date will be displayed after the calendar gets caught in a render cycle. Also added update index to the eventData object passed back from multipleRange onSelect
|
Is PR still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in multi range support via HOC via inspiration from withMultipleDates and withRange
withMultipleRanges(Calendar)
Click anywhere on established ranges to modify. By clicking on the start date during modification range is deleted.
Header functionality is a combo of withRange and withMultipleDates. Shows whatever range is active. Can toggle between ranges with arrows as in withMultipleDates. By clicking on year, show range selection (also toggleable with arrows), clicking day on header focuses day.
This is my First PR, please feel free to offer critiques and advice ^.^