Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded deps #94

Merged
merged 2 commits into from Apr 16, 2019
Merged

Upgraded deps #94

merged 2 commits into from Apr 16, 2019

Conversation

clementallen
Copy link
Owner

Closes #93

@TravisBuddy
Copy link

Travis tests have failed

Hey @clementallen,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 8

View build log

npm run cover 
> smithers@0.4.0 cover /home/travis/build/clementallen/smithers
> nyc --reporter=lcov npm test


> smithers@0.4.0 test /home/travis/build/clementallen/smithers
> nyc mocha ./test/**/*.test.js --require @babel/register --require @babel/polyfill --require ./test/base



  Caller
    get
      ✓ should resolve with the correct data
      ✓ should resolve with a standard message if response.data is empty
      ✓ should reject if response errors
      ✓ should call axios with the instance config if no separate config provided
      ✓ should call axios with the individual config if provided
    post
      ✓ should resolve with the correct data
      ✓ should resolve with a standard message if response.data is empty
      ✓ should reject if response errors
      ✓ should call axios with the instance config if no separate config provided
      ✓ should call axios with the individual config if provided

  Smithers
    init
      ✓ should set the crumb details in the instance config
      ✓ should handle crumb errors
    getInfo
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    getJobInfo
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    startBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    stopBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
      ✓ should throw an error if the buildNumber parameter is not provided
    getLastBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    getLastSuccessfulBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    getLastStableBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    getLastUnsuccessfulBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    getLastFailedBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    getSpecificBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
      ✓ should throw an error if the buildNumber parameter is not provided
    getConfigXML
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    getOverallLoad
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    getQueue
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    getView
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should call Caller.get with the default view name if none provided
    restart
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    safeRestart
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    startQuietDown
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    stopQuietDown
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    getWhoAmI
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters


  82 passing (117ms)

/home/travis/build/clementallen/smithers/node_modules/nyc/index.js:440
      if (parentInfo.children.indexOf(info.uuid) === -1) {
                     ^

TypeError: Cannot read property 'children' of undefined
    at infos.forEach.info (/home/travis/build/clementallen/smithers/node_modules/nyc/index.js:440:22)
    at Array.forEach (<anonymous>)
    at NYC.writeProcessIndex (/home/travis/build/clementallen/smithers/node_modules/nyc/index.js:437:9)
    at /home/travis/build/clementallen/smithers/node_modules/nyc/bin/nyc.js:68:9
    at ChildProcess.<anonymous> (/home/travis/build/clementallen/smithers/node_modules/foreground-child/index.js:52:5)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at maybeClose (internal/child_process.js:915:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
npm ERR! Test failed.  See above for more details.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! smithers@0.4.0 cover: `nyc --reporter=lcov npm test`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the smithers@0.4.0 cover script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2019-04-16T14_44_43_963Z-debug.log
TravisBuddy Request Identifier: 2ff0e080-6056-11e9-b35f-176b031e922f

@coveralls
Copy link

coveralls commented Apr 16, 2019 •
edited

Coverage Status

Coverage remained the same at 92.982% when pulling c5782bc on deps into 5d03a6e on master.

@TravisBuddy
Copy link

Travis tests have failed

Hey @clementallen,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 8

View build log

npm run cover 
> smithers@0.4.0 cover /home/travis/build/clementallen/smithers
> nyc --reporter=lcov npm test


> smithers@0.4.0 test /home/travis/build/clementallen/smithers
> nyc mocha ./test/**/*.test.js --require @babel/register --require @babel/polyfill --require ./test/base



  Caller
    get
      ✓ should resolve with the correct data
      ✓ should resolve with a standard message if response.data is empty
      ✓ should reject if response errors
      ✓ should call axios with the instance config if no separate config provided
      ✓ should call axios with the individual config if provided
    post
      ✓ should resolve with the correct data
      ✓ should resolve with a standard message if response.data is empty
      ✓ should reject if response errors
      ✓ should call axios with the instance config if no separate config provided
      ✓ should call axios with the individual config if provided

  Smithers
    init
      ✓ should set the crumb details in the instance config
      ✓ should handle crumb errors
    getInfo
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    getJobInfo
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    startBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    stopBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
      ✓ should throw an error if the buildNumber parameter is not provided
    getLastBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    getLastSuccessfulBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    getLastStableBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    getLastUnsuccessfulBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    getLastFailedBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    getSpecificBuild
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
      ✓ should throw an error if the buildNumber parameter is not provided
    getConfigXML
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should throw an error if the name parameter is not provided
    getOverallLoad
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    getQueue
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    getView
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
      ✓ should call Caller.get with the default view name if none provided
    restart
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    safeRestart
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    startQuietDown
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    stopQuietDown
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters
    getWhoAmI
      ✓ should resolve with Caller response
      ✓ should reject with Caller error
      ✓ should call Caller.get with the expected parameters


  82 passing (100ms)

/home/travis/build/clementallen/smithers/node_modules/nyc/index.js:440
      if (parentInfo.children.indexOf(info.uuid) === -1) {
                     ^

TypeError: Cannot read property 'children' of undefined
    at infos.forEach.info (/home/travis/build/clementallen/smithers/node_modules/nyc/index.js:440:22)
    at Array.forEach (<anonymous>)
    at NYC.writeProcessIndex (/home/travis/build/clementallen/smithers/node_modules/nyc/index.js:437:9)
    at /home/travis/build/clementallen/smithers/node_modules/nyc/bin/nyc.js:68:9
    at ChildProcess.<anonymous> (/home/travis/build/clementallen/smithers/node_modules/foreground-child/index.js:52:5)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at maybeClose (internal/child_process.js:915:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
npm ERR! Test failed.  See above for more details.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! smithers@0.4.0 cover: `nyc --reporter=lcov npm test`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the smithers@0.4.0 cover script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2019-04-16T14_45_41_027Z-debug.log
TravisBuddy Request Identifier: 59be79e0-6056-11e9-b35f-176b031e922f

@TravisBuddy
Copy link

Hey @clementallen,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 81352e20-605a-11e9-b35f-176b031e922f

@clementallen
Copy link
Owner Author

Fix pushed following advice in nyc repo: istanbuljs/nyc#1067 (comment)

@clementallen clementallen merged commit 02dbaf5 into master Apr 16, 2019
@clementallen clementallen deleted the deps branch April 16, 2019 15:16
@clementallen clementallen mentioned this pull request Apr 16, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clementallen @TravisBuddy @coveralls