Add configs #23
Add configs #23
Conversation
| "plugin:local-rules/error" | ||
| ] | ||
| } | ||
| ``` |
There was a problem hiding this comment.
I added this on top because I think that it's the most common usage and it has the least amount of config
index.js
Outdated
| @@ -26,6 +26,18 @@ if (!rules) { | |||
| ); | |||
| } | |||
|
|
|||
| function getConfig(type) { | |||
| return { | |||
| rules: Object.fromEntries(Object.keys(rules).map((rule) => { | |||
There was a problem hiding this comment.
Object.fromEntries is Node 12+ by the way.
There was a problem hiding this comment.
Thanks for calling this out! I'll make this a major version change.
index.js
Outdated
| @@ -26,6 +26,19 @@ if (!rules) { | |||
| ); | |||
| } | |||
|
|
|||
| function getConfig(type) { | |||
There was a problem hiding this comment.
nit: Update style to match
- " -> '
- add semicolons
- add trailing commas
There was a problem hiding this comment.
It would be good to set up linting and CI in this repo to enforce this kind of rules 😁
Done
index.js
Outdated
| module.exports = { | ||
| configs: { | ||
| error: getConfig("error"), | ||
| warn: getConfig("warn"), |
There was a problem hiding this comment.
Let's rename this to 'all-warn'.
That said, as an aside, severity "warn"
is typically used when introducing a new rule that will eventually be set to "error"
(source)
So I'm not sure how common it is to want everything to be warn.
I think a useful follow-on PR would be to add support for an optional severity field inside rules' docs field (since plugins are allowed to put whatever they want there) that getConfig would check first and use the value of that field when present, allowing individual rules to set themselves to warn while the rest are still error.
module.exports = {
'disallow-identifiers': {
meta: {
docs: {
description: 'disallow identifiers',
category: 'Possible Errors',
severity: 'warn',
},
index.js
Outdated
| module.exports = { | ||
| configs: { | ||
| error: getConfig("error"), |
There was a problem hiding this comment.
Let's rename error to all. It looks to be normal for all to set all rules to severity error: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/all.ts
|
Sorry for the early review! Wasn't aware of the "ready for review" feature. |
|
Should be all done |
|
How can we move this forward? |
Closes #22
Missing: