Use go-gh config package #5771
Merged
Use go-gh config package #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcoe
force-pushed
the
config-integration
branch
from
484ecd5
to
1379d17
Compare
samcoe
commented
Jun 8, 2022
| ghrepo.SetDefaultHost(host) | ||
| } | ||
| host, _ := cfg.DefaultHost() | ||
| ghrepo.SetDefaultHost(host) |
There was a problem hiding this comment.
After this change we will be able to remove this and use ghAuth.DefaultHost() inside of ghrepo instead of the defaultHostOverride variable.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
samcoe
force-pushed
the
config-integration
branch
3 times, most recently
from
1e0d995
to
e64b4f4
Compare
samcoe
force-pushed
the
config-integration
branch
from
e64b4f4
to
35b8c35
Compare
samcoe
force-pushed
the
config-integration
branch
from
35b8c35
to
ed43b78
Compare
mislav
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Thanks for the giant body of work!
This diff could have been potentially made smaller by keeping some old interfaces and their return values the same: the Aliases API, for example, cfg.Set, and DefaultHost. If something used to return an error before but doesn't anymore, it would have been fine to keep returning a nil error (for example). But now that you've already done the legwork to rewrite all the call points, I guess that's fine!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all uses of
configto now use thego-ghconfigpackage. The majority of non-test file changes are just modifying the return values fromcfg.DefaultHost(), since it no longer returns an error.Follow up to cli/go-gh#44 and cli/go-gh#45.
cc #5560