Migrate to go-gh text package #6236
Conversation
samcoe
force-pushed
the
integrate-text-package
branch
6 times, most recently
from
e4bde1f
to
48ba566
Compare
samcoe
force-pushed
the
integrate-text-package
branch
from
48ba566
to
7c2d67e
Compare
| return updaterEnabled != "" && !isCI() && isTerminal(os.Stdout) && isTerminal(os.Stderr) | ||
| } | ||
|
|
||
| func isTerminal(f *os.File) bool { |
There was a problem hiding this comment.
This function also exists unexported in the iostreams package, I had inlined it here from the utils package. Should we export it from iostreams to prevent this duplication?
There was a problem hiding this comment.
It's fine like this. I will take care of this when I start dogfooding iostreams stuff from go-gh; thanks!
| @@ -498,3 +498,12 @@ func buildDisplayName(displayName string, prebuildAvailability string) string { | |||
| return displayName | |||
| } | |||
| } | |||
|
|
|||
| func stringInSlice(a string, slice []string) bool { | |||
| } | ||
|
|
||
| // RemoveExcessiveWhitespace returns a copy of the string s with excessive whitespace removed. | ||
| func RemoveExcessiveWhitespace(s string) string { |
There was a problem hiding this comment.
This used to be called ReplaceExcessiveWhitespace but RemoveExcessiveWhitespace seemed more descriptive.
| return text.Pluralize(num, thing) | ||
| } | ||
|
|
||
| func FuzzyAgo(a, b time.Time) string { |
There was a problem hiding this comment.
FuzzyAgo used to take in a time.Duration argument but I changed it to take in two time.Time arguments to match FuzzyAgoAbbr. Also the call sites were using time.Since or time.Sub to create the time.Duration argument so that is now simplified and taken care of by the function.
| @@ -764,4 +764,16 @@ func generateCompareURL(ctx CreateContext, state shared.IssueMetadataState) (str | |||
| return url, nil | |||
| } | |||
|
|
|||
| // Humanize returns a copy of the string s that replaces all instance of '-' and '_' with spaces. | |||
| func humanize(s string) string { | |||
| @@ -44,6 +44,11 @@ func WithPrAndIssueQueryParams(client *api.Client, baseRepo ghrepo.Interface, ba | |||
| return u.String(), nil | |||
| } | |||
|
|
|||
| // Maximum length of a URL: 8192 bytes | |||
| func ValidURL(urlStr string) bool { | |||
| @@ -330,3 +329,7 @@ func forkRun(opts *ForkOptions) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func isURL(s string) bool { | |||
| @@ -140,3 +139,29 @@ func formatKeywords(ks []string) []string { | |||
| } | |||
| return ks | |||
| } | |||
|
|
|||
| // CamelToKebab returns a copy of the string s that is converted from camel case form to '-' separated form. | |||
| func camelToKebab(s string) string { | |||
This PR replaces existing uses of text utilities with the
go-ghtextpackage. Similar to how I have done other replacements I created an internaltextpackage which lightly wraps thego-ghtextpackage in order to simplify call sites and consolidatetextutility functions outside of theutilspackage. Theutilspackage was very sparse so I also consolidated that into one file with the two functions that are still left in it (excluding table printer).follow up to cli/go-gh#69
cc #5544