-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create HSM testing workflow #8421
Merged
Merged
Commits on Dec 5, 2023
-
This commit is an initial prototype based on the deployment workflow, using the Azure Code Signing service to sign Windows .exe and .msi files. These changes have been isolated as much as possible to not affect existing deployment workflows while also working around design issues with how GitHub CLI workflow works with GoReleaser and now with ACS support. The biggest smell was over whether to break from using GoReleaser or have GoReleaser control as much about the release process as it has been versus opening / signing / archiving the resulting GoReleaser artifacts; needless to say, the latter was chosen for expedience as well as leaning into officially supported solutions.
Configuration menu - View commit details
-
Copy full SHA for dea2cd5 - Browse repository at this point
Copy the full SHA dea2cd5View commit details
Commits on Dec 8, 2023
-
Update HSM test using Desktop approach
This update leverages GitHub Desktop approach of downloading Azure Code Signing DLL and wiring it up as part of the existing signing process used by Windows builds.
Configuration menu - View commit details
-
Copy full SHA for 5e8e645 - Browse repository at this point
Copy the full SHA 5e8e645View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0af95d9 - Browse repository at this point
Copy the full SHA 0af95d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4054968 - Browse repository at this point
Copy the full SHA 4054968View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f8d2f7 - Browse repository at this point
Copy the full SHA 4f8d2f7View commit details
Commits on Dec 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1fff21a - Browse repository at this point
Copy the full SHA 1fff21aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bcbd848 - Browse repository at this point
Copy the full SHA bcbd848View commit details -
Configuration menu - View commit details
-
Copy full SHA for 783dbf9 - Browse repository at this point
Copy the full SHA 783dbf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35f99ee - Browse repository at this point
Copy the full SHA 35f99eeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.