Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: consistent issue and PR owner/repo#number in various prompt #8778

Merged
merged 5 commits into from Mar 12, 2024
Merged

feat: consistent issue and PR owner/repo#number in various prompt #8778

merged 5 commits into from Mar 12, 2024

Commits on Mar 1, 2024

  1. feat(merge): add owner/repo in prompt 

    Various places during the `gh pr merge` flow show the PR number and
title. Those places are updated to also show the owner/repo.

E.g.
Before:
  Pull request #123 (title) is ready to be merged
After:
  Pull request owner/repo#123 (title) is ready to be merged

There are other places, where only the number is displayed. Those were
intentionally left as is. It made sense to show the owner/repo only when
the extra context of the title was present.

It also fixes the related tests.

cc #8777
    @nobe4
    nobe4 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    db93444 View commit details
    Browse the repository at this point in the history

  2. fix: format files

    @nobe4
    nobe4 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    a5b7c61 View commit details
    Browse the repository at this point in the history

  3. Apply first round of owner/repo#number consistency 

    This commit expands on @nobe4 initial work by bringing the owner and repository name to the most obvious issue and PR number output use cases before making a second pass for any edge cases.
    @andyfeller
    andyfeller committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3bb5f54 View commit details
    Browse the repository at this point in the history

  4. Enhance 2nd round of issue and PR number output

    @andyfeller
    andyfeller committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    bcdc917 View commit details
    Browse the repository at this point in the history

  5. Fix breaking test for PR/issue # change

    @andyfeller
    andyfeller committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    2b2571e View commit details
    Browse the repository at this point in the history