Migrate from httpmock to gock #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
suggested changes
May 5, 2022
| httpmock.REST("GET", "some/test/path"), | ||
| httpmock.StatusStringResponse(200, `{"message": "success"}`), | ||
| ) | ||
| gock.New("https://api.github.com"). |
There was a problem hiding this comment.
Instead of gock.New(), could we use a gock initialization method that doesn't intercept the default http.DefaultTransport, but makes a new transport that we can pass via options to RESTClient()? That way it's more clear what's being initialized, there is no reliance to global state, and we don't have to do t.Cleanup(gock.Off())
There was a problem hiding this comment.
I thought we could get around this but this check functionality deep in the gock implementation makes it infeasible.
There was a problem hiding this comment.
Ah I see; it looks like the library is designed in a way that it always wants to be used with global intercept. 👍
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates our tests from using our homemade
httpmockpackage with the third-partygockpackage.gockprovides all the functionality thathttpmockdoes and more. It also has a nice declarative DSL that is easier to understand, in my opinion. This is an alternative to #29.cc #28