Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test and lint workflow files #38

Merged
merged 1 commit into from May 9, 2022
Merged

Update test and lint workflow files #38

merged 1 commit into from May 9, 2022

Conversation

samcoe
Copy link
Contributor

@samcoe samcoe commented May 9, 2022

No description provided.

@samcoe samcoe self-assigned this May 9, 2022
@@ -1,6 +1,29 @@
name: Lint
on: [push, pull_request]
permissions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "permissions" apply to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied from https://github.com/cli/cli/blob/99952e2e271755690b9a003b4c97f4a5548e73c7/.github/workflows/lint.yml#L14, I think this means that any of the jobs in this file do not have write permissions back to the repo.

@samcoe samcoe merged commit ff0ff65 into trunk May 9, 2022
@samcoe samcoe deleted the update-workflows branch May 9, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants