Add additional API functionality #39
Conversation
samcoe
force-pushed
the
api-integration
branch
5 times, most recently
from
cabf149
to
ba8070c
Compare
| } | ||
|
|
||
| // HandleHTTPError parses a http.Response into a HTTPError. | ||
| func HandleHTTPError(resp *http.Response) error { |
There was a problem hiding this comment.
I am not in love with this name, I am open to suggestions on a better one.
There was a problem hiding this comment.
I think it's fine! Ideally, no integrators will ever need to call this directly, since all the other higher-level API methods call this internally on non-HTTP 200 statuses. However, I understand we need this from cli/cli?
There was a problem hiding this comment.
Yeah, there are numerous places in cli/cli that call api.HandleHTTPError directly rather than making requests through an api.Client interface.
| } | ||
|
|
||
| // HandleHTTPError parses a http.Response into a HTTPError. | ||
| func HandleHTTPError(resp *http.Response) error { |
There was a problem hiding this comment.
I think it's fine! Ideally, no integrators will ever need to call this directly, since all the other higher-level API methods call this internally on non-HTTP 200 statuses. However, I understand we need this from cli/cli?
This PR adds additional API functionality that is necessary for
ghto utilizego-gh.optionsNeedResolutionto avoid unnecessary config loadingapi.HandleHTTPErrorto allow users access to use our error handlingRESTClient.Rawfunction to allow users direct access to an http responsepkg/api/http.gotopkg/api/errors.goto more accurately reflect its contentsBased on top of #30
Corresponding
ghPR cli/cli#5614 that uses these changes.cc cli/cli#5560