Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export ssh package #40

Merged
merged 1 commit into from May 17, 2022
Merged

Export ssh package #40

merged 1 commit into from May 17, 2022

Conversation

samcoe
Copy link
Contributor

@samcoe samcoe commented May 16, 2022 •
edited

This PR exports the SSH package so it can be used inside of gh. It also changes the interface a bit now utilize a Translator interface as this name is more accurate.

cc cli/cli#5560
corresponds to cli/cli#5654

@samcoe samcoe self-assigned this May 16, 2022
@samcoe samcoe marked this pull request as ready for review May 16, 2022 14:14
@samcoe samcoe requested a review from mislav May 16, 2022 14:14
mislav
mislav approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@samcoe samcoe merged commit 293b1eb into trunk May 17, 2022
@samcoe samcoe deleted the ssh-integration branch May 17, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav mislav approved these changes

Assignees

@samcoe samcoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samcoe @mislav