Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for localhost #51

Merged
merged 1 commit into from Jun 22, 2022
Merged

Add support for localhost #51

merged 1 commit into from Jun 22, 2022

Conversation

samcoe
Copy link
Contributor

@samcoe samcoe commented Jun 22, 2022 •
edited

This PR adds support for github.localhost host for the api and auth packages. The logic now reflects the same logic used in cli.

Closes #48

@samcoe samcoe self-assigned this Jun 22, 2022
@samcoe samcoe marked this pull request as ready for review June 22, 2022 08:06
@samcoe samcoe requested a review from mislav June 22, 2022 08:06
@samcoe samcoe merged commit 94b0f6e into trunk Jun 22, 2022
@samcoe samcoe deleted the localhost-support branch June 22, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav mislav approved these changes

Assignees

@samcoe samcoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isEnterprise returns true incorrectly on github.localhost
2 participants
@samcoe @mislav