Do not return an error when blank config files are read #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcoe
commented
Jul 25, 2022
| @@ -91,7 +91,6 @@ func Test_sshParser_absolutePath(t *testing.T) { | |||
| parentFile string | |||
| arg string | |||
| want string | |||
| wantErr bool | |||
There was a problem hiding this comment.
This was unused so I removed it, not related to other changes in the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior when reading empty config files, previously we would return an
ErrInvalidFormatand now we will return a blank yaml map. This fixes backwards compatibility where some cli users had blankhost.ymlfiles.Fixes cli/cli#5949