Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly determine IANA Time Zone name #58

Merged
merged 1 commit into from Jul 25, 2022
Merged

Correctly determine IANA Time Zone name #58

merged 1 commit into from Jul 25, 2022

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Jul 25, 2022

Maintaining a list of UTC mappings internally wasn't a great approach due to these mappings being inaccurate during DST.

Thanks @natefinch!

Ref. cli/cli#5978
Ref. #56

@mislav
Correctly determine IANA Time Zone name
be6b414 
Maintaining a list of UTC mappings internally wasn't a great approach
due to these mappings being innacurate during DST.
samcoe
samcoe approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of not having to maintain the timezone list ourselves 👍

@mislav mislav merged commit 79f89db into trunk Jul 25, 2022
@mislav mislav deleted the tzlocal branch July 25, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcoe samcoe samcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mislav @samcoe