Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate browser package from gh #62

Merged
merged 2 commits into from Aug 8, 2022
Merged

Migrate browser package from gh #62

merged 2 commits into from Aug 8, 2022

Conversation

samcoe
Copy link
Contributor

@samcoe samcoe commented Aug 8, 2022

This PR extracts out the Browser package from gh. Functionality wise it remains the same as it was in gh. After this is merged I will make a follow up PR in cli/cli to use this extracted package.

cc cli/cli#5544

@samcoe samcoe self-assigned this Aug 8, 2022
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

pkg/browser/browser.go Outdated Show resolved Hide resolved
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little style comment

pkg/browser/browser.go Outdated Show resolved Hide resolved
@samcoe samcoe enabled auto-merge (squash) August 8, 2022 18:20
@samcoe samcoe merged commit 2a2d6b3 into trunk Aug 8, 2022
@samcoe samcoe deleted the browser branch August 8, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants