Update to support node v18+ #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are natively supported from node v18+ and the previous code wouldn't work, so best to remove these dependencies altogether.
…cies They are no longer needed as they are now globals in Node from v18+.
jacksongross
commented
Aug 10, 2023
| filename: asset.original_file, | ||
| contentType: 'application/json' | ||
| }) | ||
| form.set('access_token', accessToken) |
There was a problem hiding this comment.
The main issue I was seeing within our apps using this plugin was that the form data was not being supplied to Rollbar when making the API call from within uploadSourcemap, with API responses indicating an access token was missing, and it was definitely defined within our environment so it lead me to find that the FormData was not sending the data correctly via fetch. Then I discovered the node-fetch-native package falls back to native fetch when defined, which doesn't seem compatible with the form-data package we are using, which lead me to find form-data/form-data#551 which seems it is not necessary anymore due to being a global in node.
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package doesn't seem to work in node v18+ and I suspect its due to how
fetchis loaded withinnode-fetch-native. Considering thatFormDataandfetchare now natively supported in node from v18 we can remove these dependencies and with a few tweaks make this package work again.