Get analysis result out of tool.analyze()

[goto-bus-stop]

This way the main Clinic cli can print recommendations to the command line output, primarily for use in CI.

[AndreasMadsen]

Some feedback if you don't mind.

• "Doctor check" is cute, but I think you should choose a name that makes sense for the entire clinic suite. Maybe just analyze.

• Include the raw data, for future projects we may wish to utilize that.

• Consider excluding results.recommendation for now, it looks quite ad-hoc and I'm not sure it is required.

[AndreasMadsen]

Having visualize output a structured object is a bit odd. If anything, it should output the file stream. A better separation of logic would be collect() -> analyze() -> visualize(). Where visualize() takes the analyze() output. I do see the incompatibility, but maybe analyze() should output streams?

I don't have any strong opinions. A valid alternative is also to just force the API consumer to call both methods if they want both a structured object and a file.

[goto-bus-stop]

Yeah, I think analyze() → visualize() would be ideal, but I didn't wanna break the API 😛 I did it this way so the CLI could avoid running the analysis twice. I agree with your points tho.