Fix #2309: report unused for expression

clj-kondo · Apr 5, 2024 · 9cd2114 · 9cd2114
1 parent 0728512
commit 9cd2114
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/extract/clj_kondo/impl/extract_var_info.clj b/extract/clj_kondo/impl/extract_var_info.clj
@@ -114,7 +114,8 @@
                        #_(:pure-fn-if-fn-args-pure info))
                  (conj acc sym)
                  acc))
-             #{} var-info))
+             '#{clojure.core/for}
+             var-info))
 
 (defn print-set-sorted [s]
   (format "#{%s}"

diff --git a/src/clj_kondo/impl/var_info_gen.clj b/src/clj_kondo/impl/var_info_gen.clj
@@ -1920,6 +1920,7 @@ clojure.core/float-array
 clojure.core/float?
 clojure.core/fn?
 clojure.core/fnext
+clojure.core/for
 clojure.core/format
 clojure.core/frequencies
 clojure.core/future?

diff --git a/test/clj_kondo/unused_value_test.clj b/test/clj_kondo/unused_value_test.clj
@@ -152,4 +152,10 @@
    '({:file "<stdin>", :row 1, :col 20, :level :warning, :message "Unused value: \"hello\""}
      {:file "<stdin>", :row 1, :col 28, :level :warning, :message "Unused value"})
    (lint! "(defn foo [bar] {} \"hello\" (+ 2 2) bar)"
-             {:linters {:unused-value {:level :warning}}})))
+          {:linters {:unused-value {:level :warning}}})))
+
+(deftest issue-2309-test
+  (assert-submaps
+   '({:file "<stdin>", :row 1, :col 14, :level :warning, :message "Unused value"})
+   (lint! "(defn foo [] (for [x [1 2 3]] x) nil)"
+          {:linters {:unused-value {:level :warning}}})))