Improve bindings diagnostics and add ui tests #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
noa/improve-diagnostics
branch
from
f0f37c6
to
56df74f
Compare
Centril
requested changes
May 15, 2024
Comment on lines
+296
to
+312
| for param in &original_function.sig.generics.params { | ||
| match param { | ||
| syn::GenericParam::Lifetime(_) => {} | ||
| syn::GenericParam::Type(_) => { | ||
| return Err(syn::Error::new_spanned( | ||
| param, | ||
| "type parameters are not allowed on reducers", | ||
| )) | ||
| } | ||
| syn::GenericParam::Const(_) => { | ||
| return Err(syn::Error::new_spanned( | ||
| param, | ||
| "const parameters are not allowed on reducers", | ||
| )) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| for param in &original_function.sig.generics.params { | |
| match param { | |
| syn::GenericParam::Lifetime(_) => {} | |
| syn::GenericParam::Type(_) => { | |
| return Err(syn::Error::new_spanned( | |
| param, | |
| "type parameters are not allowed on reducers", | |
| )) | |
| } | |
| syn::GenericParam::Const(_) => { | |
| return Err(syn::Error::new_spanned( | |
| param, | |
| "const parameters are not allowed on reducers", | |
| )) | |
| } | |
| } | |
| } | |
| for param in &original_function.sig.generics.params { | |
| let err = match param { | |
| GenericParam::Lifetime(_) => continue, | |
| GenericParam::Type(_) => "type parameters are not allowed on reducers", | |
| GenericParam::Const(_) => "const parameters are not allowed on reducers", | |
| }; | |
| return Err(syn::Error::new_spanned(param, err)); | |
| } |
| @@ -294,6 +293,24 @@ fn gen_reducer(original_function: ItemFn, reducer_name: &str, extra: ReducerExtr | |||
| let func_name = &original_function.sig.ident; | |||
There was a problem hiding this comment.
This function is growing really large. Would appreciate a follow up PR to split it.
| = help: the trait `Reducer<'_, _, _>` is not implemented for fn item `fn(Test) {bad_type}` | ||
| = note: | ||
| = note: reducer signatures must match the following pattern: | ||
| = note: Fn([ReducerContext,] [T where T: SpacetimeType, ...]) [-> Result<(), impl Display>] |
There was a problem hiding this comment.
T where T: SpacetimeType looks confusable with generics, I would instead list T1, T2, ... and then say "where each T type implements SpacetimeType".
| label = "this reducer signature is not valid; parameters and return type must implement `SpacetimeType`", | ||
| note = "", | ||
| note = "reducer signatures must match the following pattern:", | ||
| note = " Fn([ReducerContext,] [T where T: SpacetimeType, ...]) [-> Result<(), impl Display>]", |
There was a problem hiding this comment.
Suggested change
| note = " Fn([ReducerContext,] [T where T: SpacetimeType, ...]) [-> Result<(), impl Display>]", | |
| note = " `Fn([ReducerContext,] [T1, ...]) [-> Result<(), impl Display>]`", | |
| note = "where each `Ti` type implements `SpacetimeType`." |
| @@ -811,7 +835,9 @@ fn spacetimedb_index( | |||
| let output = quote! { | |||
| #original_struct | |||
|
|
|||
There was a problem hiding this comment.
This feels like it deserves a comment.
Comment on lines
+790
to
+792
| // supposed to use). That is, the user doesn't see errors about `Serialize`, | ||
| // `Deserialize` not being satisfied, which they wouldn't know what to do | ||
| // about. |
There was a problem hiding this comment.
Hmm, but this doesn't seem to be the case? https://github.com/clockworklabs/SpacetimeDB/pull/1216/files#diff-d54e437b451c674788109bc2cada3b5416c6a825cc61f0c6dd520d4eb8ce29c1R54-R122
There was a problem hiding this comment.
yeah, that comment is wrong. It was there before and I just moved it, I think. I was playing around with adding where bounds like FieldType: SpacetimeType, but SpacetimeType doesn't actually imply [De]Serialize either.
Comment on lines
+517
to
+531
| match param { | ||
| syn::GenericParam::Lifetime(_) => {} | ||
| syn::GenericParam::Type(_) => { | ||
| return Err(syn::Error::new_spanned( | ||
| param, | ||
| "type parameters are not allowed on tables", | ||
| )) | ||
| } | ||
| syn::GenericParam::Const(_) => { | ||
| return Err(syn::Error::new_spanned( | ||
| param, | ||
| "const parameters are not allowed on tables", | ||
| )) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| match param { | |
| syn::GenericParam::Lifetime(_) => {} | |
| syn::GenericParam::Type(_) => { | |
| return Err(syn::Error::new_spanned( | |
| param, | |
| "type parameters are not allowed on tables", | |
| )) | |
| } | |
| syn::GenericParam::Const(_) => { | |
| return Err(syn::Error::new_spanned( | |
| param, | |
| "const parameters are not allowed on tables", | |
| )) | |
| } | |
| } | |
| let err = match param { | |
| GenericParam::Lifetime(_) => continue, | |
| GenericParam::Type(_) => "type parameters are not allowed on tables", | |
| GenericParam::Const(_) => "const parameters are not allowed on tables", | |
| }; | |
| return Err(syn::Error::new_spanned(param, err)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Wahoo Rust 1.78! Also, the symbol for a reducer in backtraces should now be something like
spacetime_module::myreducer::invokeinstead of<spacetime_module::myreducer as spacetimedb::rt::Reducer>::INVOKEExpected complexity level and risk
1 - just diagnostic changes