Skip to content

Commit

Permalink
Explain startRecordingAt with a better description
Browse files Browse the repository at this point in the history
  • Loading branch information
djalmaaraujo committed Jul 7, 2017
1 parent e0c96e1 commit 4444ed3
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
6 changes: 5 additions & 1 deletion dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15816,7 +15816,11 @@ var MicRecorder = function () {
// 128 or 160 kbit/s – mid-range bitrate quality
bitRate: 128,

// Some browsers have a weird noise when starting the recording, this removes some milliseconds of the mp3 file
// There is a known issue with some macOS machines, where the recording
// will sometimes have a loud 'pop' or 'pop-click' sound. This flag
// prevents getting audio from the microphone a few milliseconds after
// the begining of the recording. It also helps to remove the mouse
// "click" sound from the output mp3 file.
startRecordingAt: 300
};

Expand Down
2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/index.min.js.map

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion src/mic-recorder.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ class MicRecorder {
// 128 or 160 kbit/s – mid-range bitrate quality
bitRate: 128,

// Some browsers have a weird noise when starting the recording, this removes some milliseconds of the mp3 file
// There is a known issue with some macOS machines, where the recording
// will sometimes have a loud 'pop' or 'pop-click' sound. This flag
// prevents getting audio from the microphone a few milliseconds after
// the begining of the recording. It also helps to remove the mouse
// "click" sound from the output mp3 file.
startRecordingAt: 300
};

Expand Down

0 comments on commit 4444ed3

Please sign in to comment.