Parse only 10 mimeparts #53
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasst
approved these changes
Sep 10, 2021
jkemp101
reviewed
Sep 10, 2021
| for idx, mimepart in enumerate( | ||
| parsed.walk(with_self=parsed.content_type.is_singlepart()) | ||
| ): | ||
| if idx >= 10: |
There was a problem hiding this comment.
@thomasst Should we create an issue in this repo for this to further improve it? Would we want sync-engine to still create snippets but have an option to turn that functionality off?
There was a problem hiding this comment.
- We should split out higher level email parsing (that we use in Close) into a separate library. Flanker has its issues and I think we shouldn't use it.
- I don't see much value in the snippet. In general it depends on what use cases we want to support with sync-engine. For example, we don't need to store or search attachments and bodies, but not every user of sync-engine might want to re-parse emails.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally, email was still received. Will merge after tested in prod.