added support for chimesdkvoice voiceconnector - pull and event mode … #9398
Conversation
|
tests pass locally, failure appear to be in other code - dont understand, please help |
|
Try ...
Re 2) so it matches the code in https://awspolicygen.s3.amazonaws.com/js/policies.js - search for "chime" |
c7n/resources/chimesdkvoice.py
Outdated
| return tagged_resources | ||
|
|
||
|
|
||
| @resources.register('chimesdkvoice-voiceconnector') |
There was a problem hiding this comment.
regarding resource name, chime-voice-connector .. sdk is generic in this context., and voice doesn't need a repeat.
There was a problem hiding this comment.
Hi, not sure what you are proposing.
Can you clarify thanks.
The service api in boto is "chime-sdk-voice", so that seems a sensible prefix for this collection of resources. (The deprecated legacy API is "chime" but that's not the subject of this pr as far as I am aware). There is also the Aws offering ChimeSdkMeetings , these are Amazon's names for these things , IE "SDK" is actually in the name, which is unusual, but nonetheless a fact. So just using the aws given name seems most consistent.
Amongst the various resources Inside that chimesdkvoice offering we have resources named such as "phone number", "sip rules" as well as "voice profile" and "voice connector", so "voice connector" seems a logical and obvious name in this case.
And thus I guess the comitter ended up with ...
chime-sdk-voice.voiceconnector
There was a problem hiding this comment.
Hmmm. Whilst the boto API has "chime sdk voice" and "chime sdk meeting" the Aws console seems to have just "chime sdk" and it only has the voice resources.
The "chime sdk meetings" namespace and client is only accessible via the APIs .
So I dont know if all the different chime APIs and resources should be under merely "chimesdk" in the cloud custodian namespaces, or should we just make all the cc names map directly to Aws API names as this chime extension appears to be doing?
Adding fixes to support chimesdkvoice
|
tests all pass now. @kapilt - Is a name change required? As per John's comment, the service is Chime SDK Voice and the resource type is Voice Connector - https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/chime-sdk-voice.html |
|
Hi @kapilt - can this branch be merged? Or does the resource name require updating? |
just the resource name change and then I think its fine. we don't mirror the sdk name into the resource name if a shorter name suffices, |
|
@kapilt updates have been made to the name, let me know if this suffices |
|
@kapilt - all updates are complete and should be ready to merge. |
…- tests added. Please review and merge my contribution. Thank you